feat(lsp): replace on_attach with an LspAttach rule

lua/lsp.lua

@@ -1,5 +1,9 @@
+local lspattach = vim.api.nvim_create_augroup("LspMapping", { clear = true })
+
 --  This function gets run when an LSP connects to a particular buffer.
-local on_attach = function(_, bufnr)
+vim.api.nvim_create_autocmd("LspAttach", {
+  group = lspattach,
+  callback = function(args)
     -- NOTE: Remember that lua is a real programming language, and as such it is possible
     -- to define small helper and utility functions so you don't have to repeat yourself
     -- many times.
@@ -11,7 +15,7 @@ local on_attach = function(_, bufnr)
         desc = 'LSP: ' .. desc
       end
 
-    vim.keymap.set('n', keys, func, { buffer = bufnr, desc = desc })
+      vim.keymap.set('n', keys, func, { buffer = args.buf, silent = true, desc = desc })
     end
 
     nmap('<leader>rn', vim.lsp.buf.rename, '[R]e[n]ame')
@@ -46,10 +50,11 @@ local on_attach = function(_, bufnr)
     end, '[W]orkspace [L]ist Folders')
 
     -- Create a command `:Format` local to the LSP buffer
-  vim.api.nvim_buf_create_user_command(bufnr, 'Format', function(_)
+    vim.api.nvim_buf_create_user_command(args.buf, 'Format', function(_)
       vim.lsp.buf.format()
     end, { desc = 'Format current buffer with LSP' })
-end
+  end,
+})
 
 -- document existing key chains
 require('which-key').add {
@@ -186,7 +191,7 @@ local setup_godot_dap = function()
   }
 end
 
-vim.diagnostic.config({ virtual_lines = true })
+vim.diagnostic.config({ virtual_text = true })
 vim.lsp.enable({ "ltex_plus" })
 
 setup_godot_dap()