From 72b5de1af6ce53a1f69ddc546eea0952112e400b Mon Sep 17 00:00:00 2001 From: Ondrej Grover Date: Tue, 4 Feb 2014 14:14:43 +0100 Subject: [PATCH] i18n_subsites: fix HIDE_UNTRANSLATED_CONTENT 1. was removing items of an active iterator -> only first worked 2. Article inherits Page, so first check if is Article --- i18n_subsites.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/i18n_subsites.py b/i18n_subsites.py index 93078c9..34fb000 100644 --- a/i18n_subsites.py +++ b/i18n_subsites.py @@ -118,12 +118,12 @@ def update_generator_contents(generator, *args): contents = generator.pages if is_pages_gen else generator.articles hidden_contents = generator.hidden_pages if is_pages_gen else generator.drafts default_lang = generator.settings['DEFAULT_LANG'] - for content_object in contents: + for content_object in contents[:]: # loop over copy for removing if content_object.lang != default_lang: - if isinstance(content_object, Page): - content_object.status = 'hidden' - elif isinstance(content_object, Article): + if isinstance(content_object, Article): content_object.status = 'draft' + elif isinstance(content_object, Page): + content_object.status = 'hidden' contents.remove(content_object) hidden_contents.append(content_object) if not is_pages_gen: # regenerate categories, tags, etc. for articles